Merged
Conversation
🦋 Changeset detectedLatest commit: bd1ef9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-wrangler-5550You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5550/npm-package-wrangler-5550Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-wrangler-5550 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-create-cloudflare-5550 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-cloudflare-kv-asset-handler-5550npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-miniflare-5550npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-cloudflare-pages-shared-5550npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8617732955/npm-package-cloudflare-vitest-pool-workers-5550Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
CarmenPopoviciu
approved these changes
Apr 9, 2024
Contributor
|
thank you for working on this @penalosa <3 |
penalosa
force-pushed
the
penalosa/wrangler-config-schema
branch
from
a428cc1 to
21bc8e0
Compare
penalosa
force-pushed
the
penalosa/wrangler-config-schema
branch
from
21bc8e0 to
bd1ef9d
Compare
jculvey
approved these changes
Apr 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
This PR generates a JSON schema for Wrangler, as well as updating C3 templates to add a schema property to generated config file. Once merged and released, we should follow up by merging SchemaStore/schemastore#3692.
Fixes #5057, fixes #5055, fixes #3166, DEVX-1242
Author has addressed the following